Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6284: IPoE-server op-mode does not show IPv6 address field #3423

Merged
merged 1 commit into from
May 7, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op_mode ipoe_server

Proposed changes

Added IPv6 address fields ip6 | ip6-dp to show ipoe-service sessions output

How to test

set service ipoe-server authentication mode 'noauth'
set service ipoe-server client-ip-pool ONE range '100.64.0.1-100.64.0.10'
set service ipoe-server client-ipv6-pool POOL-v6 delegate 2001:db8:8003::/48 delegation-prefix '56'
set service ipoe-server client-ipv6-pool POOL-v6 prefix 2001:db8::/64
set service ipoe-server default-ipv6-pool 'POOL-v6'
set service ipoe-server default-pool 'ONE'
set service ipoe-server gateway-address '100.64.0.14/28'
set service ipoe-server interface eth1 network 'shared'
set service ipoe-server name-server '1.1.1.1'
set service ipoe-server name-server '100.64.0.14'
set service ipoe-server name-server '2001:db8::1'

vyos@vyos# run show ipoe-server sessions
ifname | username |    calling-sid    |     ip     |              ip6             | ip6-dp | rate-limit | type | comp | state  |  uptime
--------+----------+-------------------+------------+------------------------------+--------+------------+------+------+--------+----------
 ipoe0  |          | 0c:08:3f:03:00:00 | 100.64.0.1 | 2001:db8::e08:3fff:fe03:0/64 |        |            | ipoe |      | active | 00:18:32

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever sever-sever requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 7, 2024 14:15
@c-po
Copy link
Member

c-po commented May 7, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 7, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit abc327e into vyos:current May 7, 2024
8 of 9 checks passed
c-po added a commit that referenced this pull request May 7, 2024
op-mode: T6284: IPoE-server op-mode does not show IPv6 address field (backport #3423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants