Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frr: T4020: add option to define number of open file descriptors #2639

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 15, 2023

Change Summary

This allows the operator to control the number of open file descriptors each daemon is allowed to start with. The current assumed value on most operating systems is 1024.

If the operator plans to run bgp with several thousands of peers then this is where we would modify FRR to allow this to happen.

set system frr descriptors <n>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

FRR, system startup

Proposed changes

How to test

Smoketest result

[email protected]:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_frr.py
test_frr_bmp (__main__.TestSystemFRR.test_frr_bmp) ... ok
test_frr_bmp_and_snmp (__main__.TestSystemFRR.test_frr_bmp_and_snmp) ... ok
test_frr_file_descriptors (__main__.TestSystemFRR.test_01frr_file_descriptors) ... ok
test_frr_irdp (__main__.TestSystemFRR.test_frr_irdp) ... ok
test_frr_snmp_add_remove (__main__.TestSystemFRR.test_frr_snmp_add_remove) ... ok
test_frr_snmp_empty (__main__.TestSystemFRR.test_frr_snmp_empty) ... ok
test_frr_snmp_multipledaemons (__main__.TestSystemFRR.test_frr_snmp_multipledaemons) ... ok

----------------------------------------------------------------------
Ran 7 tests in 21.114s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This allows the operator to control the number of open file descriptors each
daemon is allowed to start with. The current assumed value on most operating
systems is 1024.

If the operator plans to run bgp with several thousands of peers then this is
where we would modify FRR to allow this to happen.

set system frr descriptors <n>
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team December 15, 2023 06:28
@c-po c-po marked this pull request as ready for review December 15, 2023 06:30
@vyosbot vyosbot requested a review from a team December 15, 2023 06:30
@sever-sever sever-sever merged commit 3571232 into vyos:current Dec 15, 2023
10 checks passed
@c-po
Copy link
Member Author

c-po commented Dec 15, 2023

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Dec 15, 2023

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Dec 15, 2023
frr: T4020: add option to define number of open file descriptors (backport #2639)
@c-po c-po deleted the frr-t4020 branch January 11, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants