Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: T5762: rename "virtual-host listen-port" -> "virtual-host port" #2519

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

c-po
Copy link
Member

@c-po c-po commented Nov 21, 2023

Change Summary

This complements commit f5e43b1 ("http: T5762: api: make API socket backend communication the one and only default") o we have a consistent port CLI node across VyOS components.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

https API

Proposed changes

How to test

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_https.py
test_api_auth (__main__.TestHTTPSService.test_api_auth) ... ok
test_api_config_file (__main__.TestHTTPSService.test_api_config_file) ... ok
test_api_configure (__main__.TestHTTPSService.test_api_configure) ... ok
test_api_generate (__main__.TestHTTPSService.test_api_generate) ... ok
test_api_reset (__main__.TestHTTPSService.test_api_reset) ... ok
test_api_show (__main__.TestHTTPSService.test_api_show) ... ok
test_certificate (__main__.TestHTTPSService.test_certificate) ... ok
test_server_block (__main__.TestHTTPSService.test_server_block) ... ok

----------------------------------------------------------------------
Ran 8 tests in 90.622s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This complements commit f5e43b1 ("http: T5762: api: make API socket backend
communication the one and only default") so we have a consistent port CLI node
across VyOS components.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team November 21, 2023 19:54
@jestabro jestabro merged commit af08c30 into vyos:current Nov 22, 2023
8 checks passed
@c-po c-po deleted the t5762-vhost-port branch November 22, 2023 05:50
@c-po
Copy link
Member Author

c-po commented Nov 22, 2023

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Nov 22, 2023

backport sagitta

✅ Backports have been created

sever-sever added a commit that referenced this pull request Nov 22, 2023
http: T5762: rename "virtual-host listen-port" -> "virtual-host port" (backport #2519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants