T5702: SNMP add interface-mib max-interfaces-number and prefix #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro and
c-po
and removed request for
a team
|
Why not make the CLI more generic by using: ? |
How to separate “interface interfaces-max” and “interface eth”? |
Sorry, typo - I have adjusted m initial comment |
Done! |
c-po
reviewed
Nov 5, 2023
interface-definitions/snmp.xml.in
Outdated
| <properties> | ||
| <help>Sets the interface name prefix to include in the IF-MIB data collection</help> | ||
| <valueHelp> | ||
| <format>txt</format> |
There was a problem hiding this comment.
Should we probably include proper <valueHelp> nodes for the interface types?
Like eth,br,bond.wireguard,vxlan and so on? So the users know only the text part is required and nothing like an asterisk as glob pattern?
c-po
approved these changes
Nov 5, 2023
- Allow to configure only required interface prefixes set service snmp mib interface 'eth' set service snmp mib interface 'bond' include_ifmib_iface_prefix eth bond Sets the interface name prefixes to include in the IF-MIB data collection. For servers with a large number of interfaces (ppp, dummy, bridge, etc) the IF-MIB processing will take a large chunk of CPU for ioctl calls. A set of space separated interface name prefixes will reduce the CPU load for IF-MIB processing. For example, configuring "include_ifmib_iface_prefix eth dummy lo" will include only interfaces with these prefixes and ignore all others for IF-MIB processing. - Allow to configure maximum interface number set service snmp mib interface-max '100' ifmib_max_num_ifaces NUM Sets the maximum number of interfaces included in IF-MIB data collection. For servers with a large number of interfaces (ppp, dummy, bridge, etc) the IF-MIB processing will take a large chunk of CPU for ioctl calls (on Linux). Setting a reasonable maximum for the CPU used will reduce the CPU load for IF-MIB processing. For example, configuring "ifmib_max_num_ifaces 500" will include only the first 500 interfaces based on ifindex and ignore all others for IF-MIB processing.
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Without those options we have high CPU utilization with many dynamic interfaces (ipoe/l2tp/pppoe/etc)
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
snmp
Proposed changes
How to test
VyOS configuration:
snmpd config:
Smoketest result
Checklist: