T5558: smoketest: fix nat definitions on dialup-router-medium-vpn. #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
and removed request for
a team
c-po
requested changes
Oct 29, 2023
| @@ -141,51 +141,51 @@ set interfaces wireguard wg1 peer sam preshared-key 'XpFtzx2Z+nR8pBv9/sSf7I94OkZ | |||
| set interfaces wireguard wg1 peer sam public-key 'v5zfKGvH6W/lfDXJ0en96lvKo1gfFxMUWxe02+Fj5BU=' | |||
| set interfaces wireguard wg1 port '7778' | |||
| set nat destination rule 50 destination port '49371' | |||
| set nat destination rule 50 inbound-interface 'pppoe0' | |||
There was a problem hiding this comment.
These configs represent out in the wild VyOS co digs that are known to work.
They should not be changed at all as they serve as input for the migration script. This usually means sonething is odd with the migrator
There was a problem hiding this comment.
This fixes the config test extension I wrote that checks the resulting config against expected values, not changing the config itself.
There was a problem hiding this comment.
Ah, dis not know we have an „after migration“ test, very cool
sarthurdev
approved these changes
Oct 29, 2023
c-po
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
fix nat definitions on dialup-router-medium-vpn.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
smoketest
nat
Proposed changes
How to test
Smoketest result
Checklist: