T5595 : PIM multicast bfd feature

[fett0]

add bfd for fast-convergence in multicast , also , I've created the smoke- test that were missing.

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T5595

Related PR(s)

Component(s) name

Proposed changes

How to test

vyos-cli :

set protocols pim interface eth0 bfd 'enable'
set protocols pim rp address 127.0.0.1 group '224.0.0.0/4'

frr :

vyos@test:~$ sudo vtysh -c "show run pimd"
Building configuration...

Current configuration:
!
frr version 9.0.1
frr defaults traditional
hostname test
ip pim rp 127.0.0.1 224.0.0.0/4
service integrated-vtysh-config
!
interface eth0
 ip pim
 ip pim bfd
exit

Smoketest result

vyos@test:~$  /usr/libexec/vyos/tests/smoke/cli/test_protocols_pim.py
test_pim_01_simple (__main__.TestProtocolsPIM.test_pim_01_simple) ... No Path to RP address specified: 127.0.0.1
ok
No Path to RP address specified: 127.0.0.1

----------------------------------------------------------------------
Ran 1 test in 3.213s

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[sever-sever]

If we have bfd does it mean we want to enable it? Let’s avoid enable/disable

[c-po]

Please see BGP neighbors, there is a simple bfd node that is valueless

[dmbaturin]

All nodes with values like true/false, enable/disable that still remain in the system are legacy and should be converted to valueless as soon as it's feasible. The policy not to make any new ones has been in place since Vyatta times, in fact. ;)

[c-po]

Please see BGP neighbors, there is a simple bfd node that is valueless

[c-po]

Will be implemented together with https://vyos.dev/T5733