-
Notifications
You must be signed in to change notification settings - Fork 347
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
The previous implementation did not iterate over the communit list, so only one match criteria was supported. set policy route-map FOO rule 10 action 'permit' set policy route-map FOO rule 10 set extcommunity rt '1111:2222222' worked but on the other hand this failed: set policy route-map FOO rule 20 action 'permit' set policy route-map FOO rule 20 set extcommunity rt '6500:24 6500:23 192.168.0.1:111 192.168.0.1:222'
- Loading branch information
Showing
2 changed files
with
26 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#!/usr/bin/env python3 | ||
|
||
# Copyright 2019-2022 VyOS maintainers and contributors <[email protected]> | ||
# Copyright 2019-2023 VyOS maintainers and contributors <[email protected]> | ||
# | ||
# This library is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU Lesser General Public | ||
|
@@ -28,28 +28,27 @@ if __name__ == '__main__': | |
parser: ArgumentParser = ArgumentParser() | ||
parser.add_argument('community', type=str) | ||
args = parser.parse_args() | ||
community: str = args.community | ||
if community.count(':') != 1: | ||
print("Invalid community format") | ||
exit(1) | ||
try: | ||
# try to extract community parts from an argument | ||
comm_left: str = community.split(':')[0] | ||
comm_right: int = int(community.split(':')[1]) | ||
|
||
# check if left part is an IPv4 address | ||
if is_ipv4(comm_left) and 0 <= comm_right <= COMM_MAX_2_OCTET: | ||
exit() | ||
# check if a left part is a number | ||
if 0 <= int(comm_left) <= COMM_MAX_2_OCTET \ | ||
and 0 <= comm_right <= COMM_MAX_4_OCTET: | ||
exit() | ||
|
||
except Exception: | ||
# fail if something was wrong | ||
print("Invalid community format") | ||
exit(1) | ||
|
||
# fail if none of validators catched the value | ||
print("Invalid community format") | ||
exit(1) | ||
|
||
for community in args.community.split(): | ||
if community.count(':') != 1: | ||
print("Invalid community format") | ||
exit(1) | ||
try: | ||
# try to extract community parts from an argument | ||
comm_left: str = community.split(':')[0] | ||
comm_right: int = int(community.split(':')[1]) | ||
|
||
# check if left part is an IPv4 address | ||
if is_ipv4(comm_left) and 0 <= comm_right <= COMM_MAX_2_OCTET: | ||
continue | ||
# check if a left part is a number | ||
if 0 <= int(comm_left) <= COMM_MAX_2_OCTET \ | ||
and 0 <= comm_right <= COMM_MAX_4_OCTET: | ||
continue | ||
|
||
raise Exception() | ||
|
||
except Exception: | ||
# fail if something was wrong | ||
print("Invalid community format") | ||
exit(1) |