-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor codebase with urfave/cli #120
Conversation
Still not satisfied about hot properly test it. Provably the best way should be an e2e building the binary and run it from go code. |
Containers started through this docker compose file will be in this isolated network. Note: the minimum version for the docker compose file format is 3.5 which introduces `name` for networks. This file format requires a docker engine version of 17.12.0+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactor was soooo much needed! thanks for the effort.
I have a question: is this intended to let one start multiple nigiris up on the same machine? If so the exposed ports of the services of the compose file must not be hardcoded.
At that point someone can use different data directory and manually tweak the compose that is moved there.
|
Overview
This PR starts the groundwork for #113 simplifying the codebase: the main takeway is that we do not need to load compose files and nodes' configuration files out of band (ie. installer script) but we ship them inside the compiled binary using the new
embed
package introduced in the standard library from Go 1.6This does not introduce or makes any breaking changes that can be noticed by end users of any means
Notable changes
To change datadir will be used an env var NIGIRI_DATADIR instead of a global flag, which introduces a chicken-egg problem, since in theinit
of themain.go
we check/provision the resources automatically, without using an installer script.--ci
has been added which will allow to run in headless mode (ie. without Esplora frontend) useful in continuos integration pipelines.update
command has been added to pull new docker images from the Github Container RegistryTODOs
update
command to pull down new images