Display loan types from FOLIO

[bbusenius]

This is a simple prototype of how we're displaying loan types from Folio. There's a getLoanTypeData function that retrieves the data by loanTypeId and returns it with items in formatHoldingItem. Then we just display it in the templates.

TODO

• Update ILS driver spec with new getHolding return values when merging

[demiankatz]

Thanks, @bbusenius! This is off to a great start. See below for a couple of thoughts/comments. Regarding configurability, I'm interested in your opinion, but I don't mind helping with the actual implementation part if you're short on time.

[demiankatz]

Is it necessary to check loan_type_id? If loan_type_name is the only thing you're displaying, it's probably fair to say it's the only thing that needs checking.

However, we should probably come up with a mechanism for enabling or disabling this display, since not everyone is going to want it. Any thoughts/preferences on whether it would make more sense to put something in Folio.ini or in a more general place like config.ini? (I see pros/cons to both -- if we put the setting in Folio.ini, then we can totally bypass the extra data lookup when it is not wanted and save some time/cycles... but if we put the setting in config.ini, then it's a more universal setting and will carry across all ILS drivers without having to implement things independently in all of them).

[bbusenius]

No problem @demiankatz! Ah yes, I should have caught that, regarding loan_type_id. I'll take that out. I still think it's a good idea to return it though. That way if someone needs to add custom logic for a particular case, they won't have to peg it to the string.

Regarding where to put the config, I normally look to the ILS config for something like that, however, I think you raise a good point about having it in a general place. My problem with that is that I sometimes can't find the setting. It might make it easier to decide if there was already a logical place for it in config.ini. I just browsed quickly and thought it could almost go in the Item_Status section but something about that doesn't feel quite right. Long-term it might be nice to have a "General ILS settings" section or something like that, where it's clear that the settings are related to the ILS but applied more generally. I think organizing it by "functionality" in config.ini might make it harder to locate, if that makes sense. But honestly, that's all just an initial reaction. I don't have a strong opinion about it.

[demiankatz]

Thanks, @bbusenius -- I agree that it makes sense to return the loan type ID; we just don't need to use it for anything in the default template.

The [Catalog] section of config.ini is where we put ILS-specific settings... adding a display_loan_type_in_holdings setting might make sense. (Like you, I don't have a strong opinion... but that's a brainstormed idea I could live with). :-)

[bbusenius]

That sounds OK to me @demiankatz. I'll go with that.