Skip to content

Commit

Permalink
fix(VAutocomplete/VCombobox): consistent open/close transition
Browse files Browse the repository at this point in the history
  • Loading branch information
J-Sek committed Dec 8, 2024
1 parent ca85fc0 commit f92aa98
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { forwardRefs } from '@/composables/forwardRefs'
import { useItems } from '@/composables/list-items'
import { useLocale } from '@/composables/locale'
import { useProxiedModel } from '@/composables/proxiedModel'
import { makeTransitionProps } from '@/composables/transition'

// Utilities
import { computed, mergeProps, nextTick, ref, shallowRef, watch } from 'vue'
Expand Down Expand Up @@ -87,7 +86,6 @@ export const makeVAutocompleteProps = propsFactory({
modelValue: null,
role: 'combobox',
}), ['validationValue', 'dirty', 'appendInnerIcon']),
...makeTransitionProps({ transition: false }),
}, 'VAutocomplete')

type ItemType<T> = T extends readonly (infer U)[] ? U : never
Expand Down Expand Up @@ -470,7 +468,6 @@ export const VAutocomplete = genericComponent<new <
maxHeight={ 310 }
openOnClick={ false }
closeOnContentClick={ false }
transition={ props.transition }
onAfterEnter={ onAfterEnter }
onAfterLeave={ onAfterLeave }
{ ...props.menuProps }
Expand Down
3 changes: 0 additions & 3 deletions packages/vuetify/src/components/VCombobox/VCombobox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { forwardRefs } from '@/composables/forwardRefs'
import { transformItem, useItems } from '@/composables/list-items'
import { useLocale } from '@/composables/locale'
import { useProxiedModel } from '@/composables/proxiedModel'
import { makeTransitionProps } from '@/composables/transition'

// Utilities
import { computed, mergeProps, nextTick, ref, shallowRef, watch } from 'vue'
Expand Down Expand Up @@ -91,7 +90,6 @@ export const makeVComboboxProps = propsFactory({
modelValue: null,
role: 'combobox',
}), ['validationValue', 'dirty', 'appendInnerIcon']),
...makeTransitionProps({ transition: false }),
}, 'VCombobox')

type ItemType<T> = T extends readonly (infer U)[] ? U : never
Expand Down Expand Up @@ -514,7 +512,6 @@ export const VCombobox = genericComponent<new <
maxHeight={ 310 }
openOnClick={ false }
closeOnContentClick={ false }
transition={ props.transition }
onAfterEnter={ onAfterEnter }
onAfterLeave={ onAfterLeave }
{ ...props.menuProps }
Expand Down

0 comments on commit f92aa98

Please sign in to comment.