-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pug-to-Handlebars Pipeline #501
base: main
Are you sure you want to change the base?
Conversation
@@ -3,3 +3,4 @@ foundryconfig.json | |||
dist | |||
.DS_Store | |||
.env | |||
mprocs.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured, while I'm in here, I might as well ignore the config script for the tool I use to run dev and Foundry from one terminal window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a new system in place, I think it might be beneficial to make a note of pug and a link to their documentation somewhere in CONTRIBUTING.md so the on-boarding process for new people is as smooth as possible.
Other than that, I like the look and functionality of pug from what I can see.
Absolutely correct. I'm rolling through existing templates to convert them to use Pug right now, but I'll be sure to update our documentation to mention it. |
I'll look at this after the bugfix release :) |
Intent
This changeset adds Pug to our workflow.
Pug is a less verbose templating engine that outputs to HTML-like syntax. Thankfully, for our purposes, it'll convert to Handlebars just fine.
Why the heck?