feat: implement definitions for markdown #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already supported by `vscode-markdown-languageservice`, but not implemented by `volar-service-markdown`.
remcohaszing
commented
Jan 12, 2024
| targetUri: location.uri, | ||
| targetRange: location.range, | ||
| targetSelectionRange: location.range, | ||
| })); |
There was a problem hiding this comment.
LSP allows textDocument/definitions to return Location | Location[] | LocationLink[] | null, so maybe Volar should allow this too instead of doing the this conversion.
There was a problem hiding this comment.
The ServicePlugin API required the only most demanding type because Volar needs to merge the results of multiple services behind the scenes.
|
LGMT, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already supported by
vscode-markdown-languageservice, but not implemented byvolar-service-markdown.