-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] (#573) Add option to install type definitions for the unit test framework based on the project configuration #587
Conversation
Installing type definitions for the unit tests framework based on the project configuration instead of using static definitions. Signed-off-by: Plamen Boychev <[email protected]>
Signed-off-by: Plamen Boychev <[email protected]>
Required by the linter in the CI checks. Signed-off-by: Plamen Boychev <[email protected]>
@pboychev-bcom you know that I have to beg you for Release.md right :) |
This all can be done post the setup, when you have a structure you can play around with and change, right? Do we want things to be that configurable? |
Not really. You can configure the testbed configuration, this is related to the type definitions made available in the transpilation process, it has affects two aspects:
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Plamen Boychev <[email protected]>
9c74545
to
8289de5
Compare
Done, thanks for the reminder, Veni :) |
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing
Property "test.framework.types" renamed to "test.framework.types.version". Signed-off-by: Plamen Boychev <[email protected]>
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job
The politically correct approach to telling someone "You are annoying" :D :D |
Installing type definitions for the unit tests framework based on the project configuration instead of using static definitions.
Description
Based on the configuration of the project the solution will:
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueRelated issues and PRs
Unit test framework types are static #573