Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] (#573) Add option to install type definitions for the unit test framework based on the project configuration #587

Conversation

pboychev-bcom
Copy link
Contributor

@pboychev-bcom pboychev-bcom commented Jan 8, 2025

Installing type definitions for the unit tests framework based on the project configuration instead of using static definitions.

Description

Based on the configuration of the project the solution will:

  • Remove the default dependency on static Jasmine type definitions.
  • Add dynamic dependency on the specified unit test framework type definitions, taking into consideration the specified framework, version and any explicit type definitions version.

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
  • I have added labels for implementation kind (kind/) and version type (version/)
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Related issues and PRs

Unit test framework types are static #573

Installing type definitions for the unit tests framework based on the project configuration instead of using static definitions.

Signed-off-by: Plamen Boychev <[email protected]>
@pboychev-bcom pboychev-bcom requested a review from a team as a code owner January 8, 2025 09:38
@github-actions github-actions bot added the kind/bug Something isn't working label Jan 8, 2025
Required by the linter in the CI checks.

Signed-off-by: Plamen Boychev <[email protected]>
@VenelinBakalov
Copy link
Collaborator

@pboychev-bcom you know that I have to beg you for Release.md right :)

@VenelinBakalov VenelinBakalov added version/minor Introduces a non-breaking feature or change area/tests Relates to tests and code coverage kind/feature New Feature to the project lang/java Related to Java Code and removed kind/bug Something isn't working labels Jan 10, 2025
@VenelinBakalov VenelinBakalov changed the title #573 Fix static unit test framework type definitions #573 Add option to instal type definitions for the unit test framework based on the project configuration Jan 10, 2025
@VenelinBakalov VenelinBakalov changed the title #573 Add option to instal type definitions for the unit test framework based on the project configuration [tests] (#573) Add option to instal type definitions for the unit test framework based on the project configuration Jan 10, 2025
@Michaelpalacce
Copy link
Collaborator

This all can be done post the setup, when you have a structure you can play around with and change, right? Do we want things to be that configurable?

@pboychev-bcom
Copy link
Contributor Author

This all can be done post the setup, when you have a structure you can play around with and change, right? Do we want things to be that configurable?

Not really. You can configure the testbed configuration, this is related to the type definitions made available in the transpilation process, it has affects two aspects:

  • The type definitions being available in the IDE
  • The types being available for transpiling the code to pure JS, after that you will have a testbed prepared you can copy the configuration from and modify for the tests execution.

@pboychev-bcom pboychev-bcom changed the title [tests] (#573) Add option to instal type definitions for the unit test framework based on the project configuration [tests] (#573) Add option to install type definitions for the unit test framework based on the project configuration Jan 15, 2025
@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@github-actions github-actions bot added the kind/bug Something isn't working label Jan 15, 2025
@pboychev-bcom pboychev-bcom force-pushed the fix/573-static-unit-test-framework-types branch from 9c74545 to 8289de5 Compare January 15, 2025 08:06
@pboychev-bcom
Copy link
Contributor Author

@pboychev-bcom you know that I have to beg you for Release.md right :)

Done, thanks for the reminder, Veni :)

@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

typescript/vrotest/readme.md Outdated Show resolved Hide resolved
Property "test.framework.types" renamed to "test.framework.types.version".

Signed-off-by: Plamen Boychev <[email protected]>
@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@Michaelpalacce Michaelpalacce merged commit 4ad97a6 into vmware:main Jan 15, 2025
8 checks passed
@VenelinBakalov
Copy link
Collaborator

@pboychev-bcom you know that I have to beg you for Release.md right :)

Done, thanks for the reminder, Veni :)

The politically correct approach to telling someone "You are annoying" :D :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Relates to tests and code coverage dco-required kind/bug Something isn't working kind/feature New Feature to the project lang/java Related to Java Code version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants