Customizable system resources configuration #95
+115
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvisonneau
force-pushed
the
customizable_system_resources
branch
3 times, most recently
from
63e63fe to
e98ea9d
Compare
mvisonneau
force-pushed
the
customizable_system_resources
branch
from
e98ea9d to
e475be0
Compare
This change would allow end users to specify custom system resources configuration. It should not change the existing behaviour as it keeps the defaults in place. Signed-off-by: Maxime VISONNEAU <[email protected]>
mvisonneau
force-pushed
the
customizable_system_resources
branch
from
e475be0 to
fddacd1
Compare
|
is this addressing an open issue ? (just curious) |
mvisonneau
commented
Mar 23, 2021
| free := si.FreeRam + si.BufferRam | ||
|
|
||
| if sr.Load1PerCPU > 0 && si.Loads[0] > sr.Load1PerCPU*float64(runtime.NumCPU()) { | ||
| internal.Logger.Println("taskq: consumer memory is lower than required") |
|
@rbg, unfortunately I haven't opened any related issue. My personal use case which required this change was when working within a very constraint system (<32MB) of RAM. |
|
If there is appetite to merge it, let me know and I will rebase / fix the typo, I have been using it as part of this project for a while now: https://github.com/mvisonneau/gitlab-ci-pipelines-exporter/blob/main/go.mod#L41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow end users to specify custom system resources configuration.
It should not change the existing behaviour as it keeps the defaults in place.