GitHub action container #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split into weekly run: Most issues are found on the admin user so run this one longer. Guest is only with experimental option, so check if issues from last run were fixed and try to find some new ones and stop if no issues were found in reasonable time. Team and Jury have access to a subset of admin API endpoints so are ran less often for now but longer than they were normally ran. Daily the admin role is ran to check if found issues were fixed and try to find new ones in the current code. Both jobs now use a shared workflow to remove code duplication.
By targetting the other released branches the cron is not needed. It only makes sense to look at quality issues during a bugfix as we don't want to rewrite code for released versions if it does not fix a bug.
Currently the CI ran also on forked branches. It makes sense to only run the CI for actual PRs or on pushes to prerelease (main) or released branches (8.1).
SL needs pull_request_target to upload the output which is a security risk. For all branches on a fork this would give away access to secrets. We can either trigger those manual or only do this last scan after merge (so push to main) and when there are issues fix those in a separate commit. By not limiting on which branches we trigger the contributor will on every push already get the feedback from the CI.
vmcj
force-pushed
the
main
branch
2 times, most recently
from
e452eb9 to
b628eac
Compare
vmcj
force-pushed
the
github_action_container
branch
from
4632fad to
a6ae55e
Compare
vmcj
force-pushed
the
github_action_container
branch
from
a6ae55e to
c765ae7
Compare
vmcj
force-pushed
the
github_action_container
branch
from
f37fb8c to
0f1a759
Compare
vmcj
force-pushed
the
github_action_container
branch
from
0f1a759 to
aa120c4
Compare
Not all uses are now implemented, the deprications is still missing for example. Renamed the current job which checked if our codecov was out of date to fix tab completion.
vmcj
force-pushed
the
github_action_container
branch
from
aa120c4 to
a356305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.