-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel ARC / IPEX Docker support #3713
base: dev
Are you sure you want to change the base?
Conversation
thanks for the pr, few notes below... i'd be ok with:
the rest?
cc @Disty0 |
@vladmandic Thanks for the feedback! I'll fix the submodules. It seems they got pulled in when I did the latest merge from main best I Can tell. The CONTRIBUTING file was a bit unclear - it said to fork from main, so I assumed pr should also go to main. I was planning on updating the wiki as well, so I'll drop the Expect an update. |
ah, contribution file needs an update - thanks for pointing in out. |
@vladmandic this should be good for further review now. I added a quick note to CONTRIBUTING as well. I had some edits/updates for the wiki in progress, I'll get those completed and include the updated ARC specific docker file there as well. That may be a few more days. cc @Disty0 |
Only reason we are using the CN location is because US doesn't work right now. US server is broken on Intel's side and throws 403 errors when trying to download ipex 2.5. We can simply switch back to US if this issue is fixed on Intel's side. |
Also i do have my dockerfile that only has the bare minimum for ipex if you are interested: https://github.com/Disty0/docker-sdnext-ipex/blob/main/Dockerfile |
US server seems to be working now - can you double-check? |
I agree with US being the default, download speeds of CN server is terrible. Seems like Intel updated their installation guide to use US server again but main issue on the ipex repo is still open: intel/intel-extension-for-pytorch#745 US server seems to be working fine on my end too, we can set US as the default or just switch back to US instead of adding a new env variable. |
lets do that. no need for CN-specific env variable as users can use TORCH_COMMAND env variable already also, lets not edit CONTRIBUTING in this PR, its unrelated plus i want to make larger changes there. |
@vladmandic got this PR down to the bare minimum per the conversion notes above. Should be ready for review again. |
Please also revert the Python version changes. It shouldn't log 3.9-3.12. Seeing 3.12 instead of 3.9, 3.10, 3.11 will lead people to install 3.12 and that will cause more compatibility issues. |
true. python 3.12.3 works with cuda, but anything newer than that breaks pydantic and tons of other totally unrelated packages. |
Description
Notes
IPEX supports 3.9-3.12:
https://pytorch-extension.intel.com/installation?platform=gpu&version=v2.5.10%2Bxpu&os=linux%2Fwsl2&package=pip
Environment and Testing
This was my first attempt into playing around with genai/image generation - not too familiar with all of the sampling methods, but tried a few and some differing results as can be seen in the screenshots below.
Some images images showing process/processing and gpu usage and one output file: