Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dedicated view for now playing track. #72

Merged
merged 33 commits into from
Oct 30, 2023
Merged

Show dedicated view for now playing track. #72

merged 33 commits into from
Oct 30, 2023

Conversation

vixalien
Copy link
Owner

@vixalien vixalien commented Oct 20, 2023 •
edited
Loading

fixes #41

TODO:

  • show mini player on lyrics & related pages
  • disable lyrics & related pages when no content is available
  • repeat & shuffle action state (icon-name and sensitivity)
  • make title & subtitle clickable
  • don't use the bottom bar
  • show and hide the full screen button on tap on mobile
  • allow changing track volume on mobile

Other issues

  • top result card don't have context menu
  • top result card doesn't update
  • make all search results sectioned
  • some search results don't work (afro hits, African heat)

@vixalien
Copy link
Owner Author

Screenshots

Screenshot from 2023-10-20 03-33-45

Screenshot from 2023-10-20 03-36-12

@vixalien vixalien force-pushed the now-player branch 3 times, most recently from 968aeb3 to 290ed1a Compare October 26, 2023 00:39
@vixalien
Copy link
Owner Author

More/Better screenshots.

image

image

@vixalien vixalien enabled auto-merge (rebase) October 30, 2023 23:21
vixalien added 23 commits October 31, 2023 01:32
@vixalien
add a button to collapse the HeaderBar
ac5d537
@vixalien
show title in now playing details
5a3e86d
@vixalien
hide the bottom on now playing screen on mobile
5cc6924
@vixalien
show now playing song & album
09258b8
@vixalien
show main view after navigating
da122d2
@vixalien
remove music/video counterpart switcher on full player controls
beef782
@vixalien
move the sidebar into it's own UI file
282c4ef
@vixalien
allow the PlayerScale to connect it's own listeners
84f0235
@vixalien
add controls to view window
90aaa8b
@vixalien
scroll to the currently playing item in the queue
d73b4cc
@vixalien
implement bottom details switcher
ecf122b
@vixalien
move now-playling-details to now-playing/details
d76b49b
@vixalien
show fullscreen button
a236d63
@vixalien
correctly switch the views
d5ca4c3
@vixalien
add handler for clicking on bottom player
99761ba
@vixalien
activate now-playing album and artist
6de19f9
@vixalien
pop down the view in video instead of showing main view
664eda6
@vixalien
fix scale not showing buffering value
28cabdc
@vixalien
fix lyrics and related view not updating correctly
ff01e8c
@vixalien
hide the lyrics and related views when they are unavailable
027fdc3
@vixalien
show loading icon when loading thumbnail
1ce5226
@vixalien
use FixedRatioThumbnail to implement now player video
69c2be8
@vixalien
animate the switch from video to art cover
dce2ba5
@vixalien vixalien disabled auto-merge October 30, 2023 23:40
@vixalien vixalien merged commit f137fb5 into main Oct 30, 2023
1 check passed
@vixalien vixalien deleted the now-player branch April 15, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Full screen player/«Now Playing»
1 participant
@vixalien