Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative URL in logout link #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

YKWeyer
Copy link

@YKWeyer YKWeyer commented Sep 21, 2018

Generated logout link assumes the homepage will be able to proceed to logout.

This might not always be the case, e.g if the shibboleth-protected section of a specific website is only to be found under a specific subpath (https://my-site.com/protected/my-protected-page). In those cases, using the Shibboleth Login Plugin can prevent the user to log out of the Frontend.

A quick workaround to that situation is to use a relative URL pointing to the current page being viewed + the logout get parameter

@lorenzulrich
Copy link
Member

Thanks for your contribution. While I agree that hardcoding the assumption that logout happens on the root page, I don't think that using the relative URL is a much better practise.

It would be ideal if one could configure this using FlexForm and/or TypoScript, with FlexForm having priority as usual. What do you think?

@YKWeyer
Copy link
Author

YKWeyer commented Nov 13, 2018

@lorenzulrich sorry for taking so long to come back to you

I am afraid I don't know typo well enough to answer your question. I just wanted to offer a quickfix to a bug I found installing your extension 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants