TASK: Add ckeditor update notes for future me ;)

visol · Mar 24, 2023 · b930a88 · b930a88
1 parent caefcb5
commit b930a88
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/Resources/Private/NeosUserInterface/src/ClipboardInputTransformationPlugin.js b/Resources/Private/NeosUserInterface/src/ClipboardInputTransformationPlugin.js
@@ -1,10 +1,12 @@
 
 const setTextOfElement = (textElement, newText) => {
     // todo use `UpcastWriter.createText` and `UpcastWriter.replace` but we cant get ahold of the writer until: https://github.com/neos/neos-ui/issues/3436
+    // fyi when ckeditor is updated, this property will become private one could use `_data` instead
     textElement._textData = newText
 }
 
 const traverseTextElements = (element, textElementVisitor) => {
+    // fyi when ckeditor is updated, this is deprecated and will change to "$text"
     if (element.is("text")) {
         textElementVisitor(element)
         return

diff --git a/Resources/Private/NeosUserInterface/src/index.js b/Resources/Private/NeosUserInterface/src/index.js
@@ -1,15 +1,13 @@
 import manifest from "@neos-project/neos-ui-extensibility";
 import { createClipboardInputTransformationPlugin } from "./ClipboardInputTransformationPlugin";
 
-const addPlugin = (Plugin) => (ckEditorConfiguration, options) => {
-    return {
-        ...ckEditorConfiguration,
-        plugins: [
-            ...(ckEditorConfiguration.plugins ?? []),
-            Plugin
-        ]
-    };
-};
+const addPlugin = (Plugin) => (ckEditorConfiguration, options) => ({
+    ...ckEditorConfiguration,
+    plugins: [
+        ...(ckEditorConfiguration.plugins ?? []),
+        Plugin
+    ]
+})
 
 manifest('Visol.Neos.ClipboardInputTransformation', {}, (globalRegistry, { frontendConfiguration }) => {
     const ckEditorRegistry = globalRegistry.get('ckEditor5');

diff --git a/Resources/Public/NeosUserInterface/Plugin.js.map b/Resources/Public/NeosUserInterface/Plugin.js.map