Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diakonie 482 fix for diakonie remove urldecoder #46

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Diakonie 482 fix for diakonie remove urldecoder #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c41c60
chore: fix for password
tkuzynow Jan 15, 2025
ad43484
chore: fix for password
tkuzynow Jan 15, 2025
7085069
fix: remove url decoder for passwords
tkuzynow Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/de/caritas/cob/userservice/api/adapters/web/dto/UserDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ public class UserDTO implements UserRegistrationDTO {

@NotBlank(message = "{user.password.notBlank}")
@ApiModelProperty(required = true, example = "pass@w0rd", position = 3)
@JsonDeserialize(using = UrlDecodePasswordJsonDeserializer.class)
@JsonProperty("password")
private String password;

Expand Down
2 changes: 1 addition & 1 deletion ...caritas/cob/userservice/api/workflow/delete/action/asker/DeleteRoomsAndSessionAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ protected void deleteSession(Session session, List<DeletionWorkflowError> workfl
}

void performSessionDeletion(Session session, List<DeletionWorkflowError> workflowErrors) {

deleteSessionData(session, workflowErrors);
deleteSession(session, workflowErrors);
deleteRocketChatGroup(session.getGroupId(), workflowErrors);
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/de/caritas/cob/userservice/api/helper/HelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,13 @@ public void removeHTMLFromText_ShouldNot_RemoveNewslinesFromText() {
removeHTMLFromText_Should_RemoveHtmlAndJavascriptFromText_And_ShouldNot_RemoveNewslines() {
assertEquals(TEXT_WITH_NEWLINE, Helper.removeHTMLFromText(TEXT_WITH_NEWLINE_AND_HTML_AND_JS));
}

@Test
public void shouldCorrectlyDecodePassword() {
assertEquals("password", helper.urlDecodeString("password"));
assertEquals("Test!@#$%^&*()1234", helper.urlDecodeString("Test!@#$%^&*()1234"));
assertEquals(
"_$87q,+Np4xc5+FC:Vcg7W#mx@JTE!R~2SmEuU9a>cbDNx4.Ap++rEys.%7GJ5r",
helper.urlDecodeString("_$87q,+Np4xc5+FC:Vcg7W#mx@JTE!R~2SmEuU9a>cbDNx4.Ap++rEys.%7GJ5r"));
}
}
Loading