-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub workflow to comment the SQL generated by a migration in PRs #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-d-zhang
force-pushed
the
migration-comment
branch
21 times, most recently
from
July 31, 2024 02:15
fcb0e4e
to
74b877f
Compare
jonathan-d-zhang
force-pushed
the
migration-comment
branch
2 times, most recently
from
July 31, 2024 02:22
d1d0f9d
to
b6a641a
Compare
|
jonathan-d-zhang
force-pushed
the
migration-comment
branch
from
July 31, 2024 02:25
b6a641a
to
4b0dded
Compare
|
jonathan-d-zhang
force-pushed
the
migration-comment
branch
from
July 31, 2024 11:33
0a7eb3b
to
daea450
Compare
sid-maddy
changed the title
Add github action to comment the SQL generated by a migration
Add a GitHub workflow to comment the SQL generated by a migration in PRs
Aug 3, 2024
sid-maddy
requested changes
Aug 3, 2024
Co-authored-by: Siddhesh Mhadnak <[email protected]> Signed-off-by: jonathan-d-zhang <[email protected]>
|
jonathan-d-zhang
force-pushed
the
migration-comment
branch
from
August 3, 2024 20:32
1725e57
to
14ebe3f
Compare
This avoids having to reimplement Alembic's revision graph logic. Signed-off-by: Siddhesh Mhadnak <[email protected]>
ci(migration-sql): checkout base commit to figure out the base revision
sid-maddy
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.