Used shared dragonfly logging configuration and logging middleware #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd read in logging configuration from a logger.toml file
…tiple files for different environments, and update code to use that instead
jonathan-d-zhang
requested changes
Jul 27, 2024
… git in the docker image.
This was referenced Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logging setup for mainframe to use the shared logging configuration at https://github.com/vipyrsec/dragonfly-logging-config, and the
LoggingMiddlewarethat it provides. Additionally, it also reads in logging configuration from alogger.tomlfile in thesrc/directory, so things such as the formatter to use (JSON or development) and the log level can be configured without modifying the code.Closes #289