Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump letsbuilda-pypi to v5.1.0 #199

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Bump letsbuilda-pypi to v5.1.0 #199

merged 7 commits into from
Feb 27, 2024

Conversation

Robin5605
Copy link
Contributor

letsbuilda-pypi has been updated to v5.1.0, and it uses httpx instead of requests now. This PR migrates all usage of requests to httpx.

AbooMinister25
AbooMinister25 previously approved these changes Feb 27, 2024
Copy link
Contributor

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me - The precommit hooks are failing (namely pyright, it seems), but we can address that later for the sake of getting this through quickly.

@Robin5605 Robin5605 enabled auto-merge February 27, 2024 00:50
Copy link
Contributor

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robin5605 Robin5605 merged commit 64c737c into main Feb 27, 2024
7 checks passed
@Robin5605 Robin5605 deleted the bump-lba-pypi branch February 27, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants