Add searchindex helper and console command #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapease
approved these changes
May 8, 2024
docker-compose.yml
Outdated
| @@ -28,7 +28,7 @@ services: | |||
| - XDEBUG_MODE | |||
|
|
|||
| mysql: | |||
| image: mysql:5.7.29 | |||
| image: mysql:8.0.37 | |||
tests/unit/SearchIndexHelperTest.php
Outdated
Comment on lines
29
to
33
| Craft::$app->getDb()->driverName = 'pgsql'; | ||
| $result = SearchIndex::optimize(); | ||
|
|
||
| // Assert: Verify that the result is an integer (number of rows affected) | ||
| $this->assertIsInt($result); |
There was a problem hiding this comment.
I feel like this might throw an SQL error unless our test environment is using PostgreSQL.
I'm planning to switch our CI tests to use GitHub actions. So I might be able to make a matrix of tests (one for MySQL one for PostgreSQL).
There was a problem hiding this comment.
I just merged an updated GitHub actions based test runner.
It uses a matrix to run tests with MySQL and Postgres.
It also switches the local dev environment to DDEV.
There was a problem hiding this comment.
I rebased this work and added test skipping based on db driver so the unit test works with the new matrix strategy.
nevinsm
force-pushed
the
nsm/searchindex-optimization
branch
from
c81f3db to
94e91f1
Compare
ten1seven
approved these changes
May 23, 2024
JJimmyFlynn
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we seem to have a lot of issues with the searchindex table causing performance issues on larger sites, or sites with data import features. This update should add a handy helper method that can be called from jobs, as well as the cli to optimize that problematic table.