Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frank/battery gauge improvements #366

Merged
merged 15 commits into from
Mar 6, 2024
Merged

Conversation

fwaalkens
Copy link
Contributor

No description provided.

@martinbosma martinbosma force-pushed the frank/battery-gauge-improvements branch from 6c5e7da to b78fe4f Compare February 29, 2024 08:17
@martinbosma martinbosma marked this pull request as draft February 29, 2024 08:18
@martinbosma martinbosma added this to the v3.30 milestone Feb 29, 2024
@martinbosma
Copy link
Contributor

Some improvement can be made:

1328x599, second battery is visible:
Screen Shot 2024-02-29 at 09 53 19

532x403, text op second battery is visible
Screen Shot 2024-02-29 at 09 54 39

910x473, ring interferes with discharging text:
Screen Shot 2024-02-29 at 09 55 56

346x587:
Screen Shot 2024-02-29 at 09 58 05

@fwaalkens fwaalkens marked this pull request as ready for review March 5, 2024 15:53
@fwaalkens
Copy link
Contributor Author

fwaalkens commented Mar 5, 2024

Pushed additional refactors and UI improvements regarding batteries.

image
image
image
image

@martinbosma martinbosma force-pushed the frank/battery-gauge-improvements branch from a439d97 to b967ade Compare March 6, 2024 08:43
Copy link
Contributor

@martinbosma martinbosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fwaalkens fwaalkens merged commit 0ef57a4 into master Mar 6, 2024
1 check passed
@martinbosma martinbosma deleted the frank/battery-gauge-improvements branch March 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants