js: handle empty progress delegate

velopack · Feb 27, 2024 · 4d5bb61 · 4d5bb61
1 parent d7c5f86
commit 4d5bb61
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/for-js/Velopack.js b/for-js/Velopack.js
@@ -1200,9 +1200,11 @@ class UpdateManager extends UpdateManagerSync {
     async downloadUpdatesAsync(toDownload, progress) {
         const command = this.getDownloadUpdatesCommand(toDownload);
         await nativeStartProcessAsyncReadLine(command, (data) => {
-            const p = parseInt(data);
-            if (!isNaN(p) && p > 0) {
-                progress(p);
+            if (progress && progress instanceof Function) {
+                const p = parseInt(data);
+                if (!isNaN(p) && p > 0) {
+                    progress(p);
+                }
             }
         });
     }

diff --git a/for-js/Velopack.ts b/for-js/Velopack.ts
@@ -1331,9 +1331,11 @@ export class UpdateManager extends UpdateManagerSync {
   ): Promise<void> {
     const command: string[] = this.getDownloadUpdatesCommand(toDownload);
     await nativeStartProcessAsyncReadLine(command, (data: string) => {
-      const p = parseInt(data);
-      if (!isNaN(p) && p > 0) {
-        progress(p);
+      if (progress && progress instanceof Function) {
+        const p = parseInt(data);
+        if (!isNaN(p) && p > 0) {
+          progress(p);
+        }
       }
     });
   }

diff --git a/src/include/ts_end.ts b/src/include/ts_end.ts
@@ -36,9 +36,11 @@ export class UpdateManager extends UpdateManagerSync {
     public async downloadUpdatesAsync(toDownload: VelopackAsset, progress: (arg: number) => void): Promise<void> {
         const command: string[] = this.getDownloadUpdatesCommand(toDownload);
         await nativeStartProcessAsyncReadLine(command, (data: string) => {
-            const p = parseInt(data);
-            if (!isNaN(p) && p > 0) {
-                progress(p);
+            if (progress && progress instanceof Function) {
+                const p = parseInt(data);
+                if (!isNaN(p) && p > 0) {
+                    progress(p);
+                }
             }
         });
     }