Full nacl implementation #2
Conversation
| for (let i = 0; i < data.length; i++) { | ||
| encoded.push(String.fromCharCode(data[i])); | ||
| } | ||
| return encoded.join(''); |
There was a problem hiding this comment.
looks like decode/encode latin never used in glow
There was a problem hiding this comment.
Right. But I would keep it for now, there are more classes to move from Coffeescript Glow. If we still don't need them, I'll remove these methods
| const newTimeoutId = window.setTimeout(() => { | ||
| this.guestKeys.delete(guestTag); | ||
| this.guestKeyTimeouts.delete(guestTag); | ||
| }, config.RELAY_SESSION_TIMEOUT); |
There was a problem hiding this comment.
again reyking should not depend on relays
There was a problem hiding this comment.
Let's decide in the next PR about Mailbox and Relay classes, here I simply took the implementation for the old Glow. Maybe I'll move this stuff to Relay class, or maybe we don't need it at all
| } | ||
| return encoded.join(''); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think encode and decode latint here is outdated, please see https://stackoverflow.com/questions/8936984/uint8array-to-string-in-javascript
also we havbe similar methods in nacl one of them we need to remove
There was a problem hiding this comment.
TextEncoder and TextDecoder don't work in jsdom environment, so all tests will fail. But let me think of this in the next PR, maybe I'll find a solution
| if (!this.driverInstance) { | ||
| // fallback to the default JS driver | ||
| this.driverInstance = driver || new JsNaClDriver(); | ||
| } |
There was a problem hiding this comment.
please throw an error if already was set. Developer should know if he doing something wrong
No description provided.