Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookiejar implementation. #526
base: master
Are you sure you want to change the base?
Cookiejar implementation. #526
Changes from 2 commits
4d4dd56
d1c2da3
afe131d
19b0b82
dfa5cd6
bd93cab
918f83a
62aeb5c
22084f4
28227ec
be7e6ae
6224a86
3602a4f
6a6af76
a9f4a40
0cd5fc1
9fad3e0
31e20ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you can just do
return
. No need to allocate anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure you do
defer cj.m.Unlock()
instead of doing this at the end of the function.I myself always prefer to
defer
Unlock
s as its much easier to follow the code. Alsodefer
is basically free these days so no worry about performance.