Go: Add Zcount command #2930

prateek-kumar-improving · 2025-01-08T23:29:40Z

Issue link

This Pull Request is linked to issue (URL): #2833

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Prateek Kumar <[email protected]>

yipin-chen

LGTM.

go/api/sorted_set_commands.go

go/api/options/zcount_options.go

Signed-off-by: Prateek Kumar <[email protected]>

go/api/options/zcount_options.go

go/api/sorted_set_commands.go

Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: prateek-kumar-improving <[email protected]>

Yury-Fridlyand · 2025-01-11T03:42:33Z

go/api/sorted_set_commands.go

+	//		specific score and inclusivity.
+	//
+	// Return value:
+	// 	Result[int64] - The number of members in the specified score range.


Suggested change

// Result[int64] - The number of members in the specified score range.

// The number of members in the specified score range.

Yury-Fridlyand · 2025-01-11T03:42:42Z

go/api/sorted_set_commands.go

+	//  fmt.Println(zCountResult.Value()) // Output: 3
+	//
+	// [valkey.io]: https://valkey.io/commands/zcount/
+	ZCount(key string, rangeOptions *options.ZCountRange) (Result[int64], error)


Suggested change

ZCount(key string, rangeOptions *options.ZCountRange) (Result[int64], error)

ZCount(key string, rangeOptions *options.ZCountRange) (int64, error)

Yury-Fridlyand · 2025-01-11T03:42:48Z

go/api/sorted_set_commands.go

+	//  if err!= nil {
+	//     // Print err
+	//  }
+	//  fmt.Println(zCountResult.Value()) // Output: 3


Suggested change

// fmt.Println(zCountResult.Value()) // Output: 3

// fmt.Println(zCountResult) // Output: 3

Yury-Fridlyand · 2025-01-11T03:43:13Z

go/api/sorted_set_commands.go

@@ -376,4 +376,34 @@ type SortedSetCommands interface {
 	//
 	// [valkey.io]: https://valkey.io/commands/zrevrank/
 	ZRevRankWithScore(key string, member string) (Result[int64], Result[float64], error)
+
+  // Returns the number of members in the sorted set stored at `key` with scores between `min` and `max` score.


As discussed, move the entire doc to the implementation

Yury-Fridlyand · 2025-01-11T03:43:39Z

go/api/base_client.go

+		return CreateNilInt64Result(), err
+	}
+	result, err := client.executeCommand(C.ZCount, append([]string{key}, zCountRangeArgs...))
+}


you missed handleLongResponse

might have deleted a line when resolving the merge conflict.

Yury-Fridlyand · 2025-01-11T03:43:52Z

go/api/base_client.go

@@ -1579,6 +1579,14 @@ func (client *baseClient) Persist(key string) (Result[bool], error) {
 	return handleBooleanResponse(result)
 }

+func (client *baseClient) ZCount(key string, rangeOptions *options.ZCountRange) (Result[int64], error) {


Suggested change

func (client *baseClient) ZCount(key string, rangeOptions *options.ZCountRange) (Result[int64], error) {

func (client *baseClient) ZCount(key string, rangeOptions *options.ZCountRange) (int64, error) {

return value is not nullable

Update tests accordingly

Yury-Fridlyand · 2025-01-11T03:50:29Z

go/api/options/zcount_options.go

+type (
+	InfBoundary string
+)
+
+const (
+	// The highest bound in the sorted set
+	PositiveInfinity InfBoundary = "+inf"
+	// The lowest bound in the sorted set
+	NegativeInfinity InfBoundary = "-inf"
+)
+
+// This struct represents the infinity boundary for a score range.
+type InfScoreBound struct {
+	value InfBoundary
+}
+
+// Create a new infinite score boundary
+func NewInfScoreBoundBuilder(value InfBoundary) *InfScoreBound {
+	return &InfScoreBound{value: value}
+}
+
+func (infScoreBound *InfScoreBound) ToArgs() ([]string, error) {
+	return []string{string(infScoreBound.value)}, nil
+}
+
+// This struct represents score boundary for a bound.
+type ScoreBoundary struct {
+	bound       float64
+	isInclusive bool
+}
+
+// Create a new score boundary.
+func NewScoreBoundaryBuilder() *ScoreBoundary {
+	return &ScoreBoundary{isInclusive: true}
+}
+
+// Set the bound for a score boundary.
+func (scoreBoundary *ScoreBoundary) SetBound(bound float64) *ScoreBoundary {
+	scoreBoundary.bound = bound
+	return scoreBoundary
+}
+
+// Set if the bound for a score boundary is inclusive or not inclusive in the boundary.
+func (scoreBoundary *ScoreBoundary) SetIsInclusive(isInclusive bool) *ScoreBoundary {
+	scoreBoundary.isInclusive = isInclusive
+	return scoreBoundary
+}
+
+func (scoreBoundary *ScoreBoundary) ToArgs() ([]string, error) {
+	args := []string{}
+	if !scoreBoundary.isInclusive {
+		args = append(args, "("+utils.FloatToString(scoreBoundary.bound))
+	} else {
+		args = append(args, utils.FloatToString(scoreBoundary.bound))
+	}
+	return args, nil
+}


all this already implemented in another file

Go: Zcount command

197c965

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 8, 2025 23:29 — with GitHub Actions Error

Go: Zcount remove options.go file

ab1f617

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 8, 2025 23:31 — with GitHub Actions Error

prateek-kumar-improving added 2 commits January 8, 2025 15:44

Go: Added Range options

4494208

Signed-off-by: Prateek Kumar <[email protected]>

Go: Update test cases

01e3e67

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 09:45 — with GitHub Actions Error

Merge branch 'main' into go-zcount-command

a15e8eb

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 09:50 — with GitHub Actions Error

Go: ZCount: Add test and update documentation

f919b62

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 17:44 — with GitHub Actions Error

prateek-kumar-improving mentioned this pull request Jan 9, 2025

Go: Sorted set commands support, part I (public preview) #2833

Open

8 tasks

prateek-kumar-improving changed the title ~~Go: Zcount command~~ Go: Add Zcount command Jan 9, 2025

Go: changelog.md file updated

0f7df19

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 17:49 — with GitHub Actions Error

Go: Zcount documentation updated

6c66640

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 17:58 — with GitHub Actions Error

prateek-kumar-improving marked this pull request as ready for review January 9, 2025 17:58

prateek-kumar-improving requested a review from a team as a code owner January 9, 2025 17:59

prateek-kumar-improving requested review from yipin-chen, Yury-Fridlyand and tjzhang-BQ and removed request for Yury-Fridlyand January 9, 2025 17:59

Go: Zcount fix formatting

acd4f7d

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 18:09 — with GitHub Actions Error

Merge branch 'main' into go-zcount-command

cde0adb

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 18:10 — with GitHub Actions Error

yipin-chen approved these changes Jan 9, 2025

View reviewed changes

yipin-chen requested a review from Yury-Fridlyand January 9, 2025 18:46

tjzhang-BQ reviewed Jan 9, 2025

View reviewed changes

go/api/sorted_set_commands.go Show resolved Hide resolved

Yury-Fridlyand reviewed Jan 9, 2025

View reviewed changes

go/api/options/zcount_options.go Outdated Show resolved Hide resolved

Update ZCountRange builder

e187bf7

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 9, 2025 20:09 — with GitHub Actions Error

Yury-Fridlyand reviewed Jan 10, 2025

View reviewed changes

go/api/options/zcount_options.go Outdated Show resolved Hide resolved

go/api/options/zcount_options.go Outdated Show resolved Hide resolved

go/api/options/zcount_options.go Outdated Show resolved Hide resolved

go/api/sorted_set_commands.go Outdated Show resolved Hide resolved

Go: Review comments fixed

ee3ff0e

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 10, 2025 02:12 — with GitHub Actions Error

Go: Fix review comments

dee5043

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 10, 2025 02:14 — with GitHub Actions Error

Go: review comments fixed

eb5bd11

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS January 10, 2025 02:17 — with GitHub Actions Error

Merge branch 'main' into go-zcount-command

3f6ee4b

Signed-off-by: prateek-kumar-improving <[email protected]>

prateek-kumar-improving requested a deployment to AWS_ACTIONS January 11, 2025 02:12 — with GitHub Actions Waiting

yipin-chen mentioned this pull request Jan 11, 2025

Go: add ZCount #2848

Closed

6 tasks

Yury-Fridlyand reviewed Jan 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go: Add Zcount command #2930

Go: Add Zcount command #2930

prateek-kumar-improving commented Jan 8, 2025 •

edited

Loading

yipin-chen left a comment

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

prateek-kumar-improving Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

Yury-Fridlyand Jan 11, 2025

	// Result[int64] - The number of members in the specified score range.
	// The number of members in the specified score range.

	ZCount(key string, rangeOptions *options.ZCountRange) (Result[int64], error)
	ZCount(key string, rangeOptions *options.ZCountRange) (int64, error)

	// fmt.Println(zCountResult.Value()) // Output: 3
	// fmt.Println(zCountResult) // Output: 3

	func (client baseClient) ZCount(key string, rangeOptions options.ZCountRange) (Result[int64], error) {
	func (client baseClient) ZCount(key string, rangeOptions options.ZCountRange) (int64, error) {

Go: Add Zcount command #2930

Are you sure you want to change the base?

Go: Add Zcount command #2930

Conversation

prateek-kumar-improving commented Jan 8, 2025 • edited Loading

Issue link

Checklist

yipin-chen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prateek-kumar-improving commented Jan 8, 2025 •

edited

Loading