-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add endpoint detection #20567
base: main
Are you sure you want to change the base?
feat: add endpoint detection #20567
Conversation
Test Results1 159 files ±0 1 159 suites ±0 1h 32m 47s ⏱️ - 2m 37s Results for commit 281f16a. ± Comparison against base commit bcd7a0d. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinServletContextInitializer.java
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinServletContextInitializer.java
Show resolved
Hide resolved
For reviewers to test this:
|
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeTasks.java
Outdated
Show resolved
Hide resolved
@mshabarov When you have time could you check that it still works for your use case with the latest change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test manually with the following scenarios:
- Vaadin app has only Java views and a ReactAdapter
- Vaadin app has only TS view
- Vaadin app has a TS view and a ReactAdapter.
Works as expected. LGTM.
|
7ca001f
to
9a1c149
Compare
Quality Gate passedIssues Measures |
Add check for if endpoint generator needs to run
Fixes #20289
Fixes #18800