-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger doc build all condition #2242
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Would the problem that this PR addresses get fixed as part of this other PR? |
…nd sklearn doc build
…d circular import
Hi David, |
@@ -17,8 +17,7 @@ | |||
trigger: | |||
branches: | |||
include: | |||
- main | |||
- rls/* | |||
- "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the motivation for including other branches here?
displayName: 'Build daal4py/sklearnex' | ||
- script: | | ||
echo "Current directory3: $(pwd)" | ||
ls -l daal4py/ | ||
ls -l build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary folder which is created during package build. It should not import modules from it. These get copied elsewhere where the importable package lives.
export LD_LIBRARY_PATH=$(dirname $(dirname $(which python)))/lib:$LD_LIBRARY_PATH | ||
echo "LD_LIBRARY_PATH: $LD_LIBRARY_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LD_LIBRARY_PATH
should not be needed. If this is for the oneDAL C++ library, be aware that there's an option --abs-rpath
in the setup.py
file as described in the installation instructions:
https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/INSTALL.md#build-intelr-extension-for-scikit-learn
@@ -65,16 +64,37 @@ jobs: | |||
displayName: 'Install requirements' | |||
- script: | | |||
export PREFIX=$(dirname $(dirname $(which python))) | |||
export DALROOT=$PREFIX | |||
export e=$PREFIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an arbitrary name that you chose, or does some other step in the current code reference a variable 'e'?
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance