Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build syntax error in < node16 #365

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: fix build syntax error in < node16 #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/esbuild/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function getEsbuildPlugin<UserOptions = Record<string, never>>(
loader.onLoadCb = callback
},
onTransform(_options, callback) {
loader.options ||= _options
loader.options = loader.options || _options
loader.onTransformCb = callback
},
} as EsbuildPluginBuild)
Expand All @@ -95,7 +95,7 @@ export function getEsbuildPlugin<UserOptions = Record<string, never>>(
break
}

result ||= {}
result = result || {}

for (const { options, onTransformCb } of loaders) {
if (!checkFilter(options))
Expand All @@ -105,7 +105,7 @@ export function getEsbuildPlugin<UserOptions = Record<string, never>>(
// caution: 'utf8' assumes the input file is not in binary.
// if you want your plugin handle binary files, make sure to
// `plugin.load()` them first.
result.contents ||= await fs.promises.readFile(args.path, 'utf8')
result.contents = result.contents || await fs.promises.readFile(args.path, 'utf8')

const _result = await onTransformCb({
...result,
Expand Down