fix(format): allow calls with partial arguments (#198)

unjs · Jan 9, 2025 · 4353c6a · 4353c6a
1 parent ef12c12
commit 4353c6a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/_path.ts b/src/_path.ts
@@ -250,7 +250,10 @@ export const dirname: typeof path.dirname = function (p) {
 };
 
 export const format: typeof path.format = function (p) {
-  const segments = [p.root, p.dir, p.base ?? p.name + p.ext].filter(Boolean);
+  const ext = p.ext ? (p.ext.startsWith(".") ? p.ext : `.${p.ext}`) : "";
+  const segments = [p.root, p.dir, p.base ?? (p.name ?? "") + ext].filter(
+    Boolean,
+  ) as string[];
   return normalizeWindowsPath(
     p.root ? resolve(...segments) : segments.join("/"),
   );

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -153,6 +153,10 @@ runTest("format", format, [
   [{ root: "/", base: "file.txt", ext: "ignored" }, "/file.txt"],
   [{ root: "/", name: "file", ext: ".txt" }, "/file.txt"],
   [{ name: "file", ext: ".txt" }, "file.txt"],
+  [{ name: "file" }, "file"],
+  [{ ext: "ext" }, ".ext"],
+  [{ ext: ".ext" }, ".ext"],
+  [{ dir: "/foo", name: "file" }, "/foo/file"],
 
   // Windows
   [{ name: "file", base: "file.txt" }, "file.txt"],