-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cmake as a build system #53
Conversation
Co-authored-by: K.Takata <[email protected]>
- Add options to build shared library - Update README.md
…passed -release option of libtool We have used Autotools for building libreadtags.so. To support both Autotools and Cmake, we must clarify what the maintainer has to do when releasing a new version. An issue supporting multiple build-sys is the consistency of the interface version of libreadtags.so. If we use only Autotools, what the maintainer has to do is just update LT_VERSION in configure.ac. libtool calculates the string appended to libreadtags.so.<>. When building libreadtags.so, cmake doesn't use libtool. To make the name of the library file the same in both build systems, the maintainer may have to specify the string calculated by libtool to BUILD_VERSION of CMakeLists.txt. To avoid a potential mistake, I decided to record the strings to configure.ac. Signed-off-by: Masatake YAMATO <[email protected]>
…rface versions Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
@ParticleG You wrote in #51:
I would like to know more about this. |
README.md
Outdated
|
||
### Build | ||
```shell | ||
./autogen.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is for the source code cloned from the git repository.
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Hmmm, currently I wrote a custom include(FetchContent)
if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/cmake/libreadtags-master.zip")
FetchContent_Declare(
libreadtags
URL file://${CMAKE_CURRENT_SOURCE_DIR}/cmake/libreadtags-master.zip
)
else ()
FetchContent_Declare(
libreadtags
GIT_REPOSITORY https://github.com/ParticleG/libreadtags.git
GIT_TAG master
)
endif ()
FetchContent_MakeAvailable(libreadtags) If you want to use this IN |
Also CMake come along with a testing tool called |
@ParticleG thank you for the information. I'm interested in registering libreadtags to vckg. However, I cannot put it as a high-priority item in my queue. Using CTest is more interesting. Anyway, I will merge this. |
@ParticleG, thank you very much. I'm thinking about releasing a new version. |
I can try making a port and create a PR to vcpkg, if you want. But I'm quite busy this month, so this could go slowly |
This is mostly based on @ParticleG's work. See #51.