Rewrite gpo_member_photos.py to use Pictorial API #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to fix some missing bioguide ids for 36 legislators, but it's a start. See unitedstates#221
Pictorial IDs are in unitedstates/congress-legislators since this PR: unitedstates/congress-legislators#943 Now that we have Pictorial IDs, we can use the Pictorial API to download those images directly rather than scraping. Fixes unitedstates#221
hugovk
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Thanks for this!
Would you be interested in joining this project as maintainer? I've not really had time to look after this repo lately, plus I don't live in the US or use this data any more :)
I don't actually have the rights to give merge rights out, but we can find someone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the United States. (In general, works of the federal government should satisfy
this criteria.)
Fixes #221