This repository has been archived by the owner on May 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
UNC Env Check fixes. #24
Open
RexiRexii
wants to merge
12
commits into
unified-naming-convention:main
Choose a base branch
from
RexiRexii:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMG THE DEV THAT MADE THIS SHOULD DIE
getconnections should only check for common things.
put consoleinfo on test() for debugging purposes gethiddenproperty and sethiddenproperty returning their actual output crypt.encrypt and crypt.decrypt standartization getconnections should only check for common stuff
removed the isrenderobj requirement from Drawing.new, as it is not a common / required function for an exploit to run properly. instead i added a check. If the exploit doesn't support isrenderobj it shall put a note instead.
-- deprecated the usage of getscriptbytecode from loadstring, do not make a simple function call a function that most exploits dont have. -- deprecated the last setscriptable / sethiddenproperty assertion, they are simply wrong and shouldn't be there - as per stated -- getscriptbytecode should be *optional*, it is not required in order to have a fully working executor
RexiRexii
commented
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- deprecated usage of getscriptbytecode in loadstring test, its not required
- deprecated last assertion inside setscriptable, whoever made that needs to get a checkup
- deprecated last assertion(s) of gethiddenproperty and sethiddenproperty
- getscriptbytecode needs to be optional it is not required in order to have a fully functioning exploit
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put consoleinfo on test() for debugging purposes
gethiddenproperty and sethiddenproperty returning their actual output
crypt.encrypt and crypt.decrypt standartization
getconnections should only check for common stuff