Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22953 MF2: Allow unpaired surrogates in text and quoted literals #3256

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Oct 25, 2024

In a previous version of the spec, unpaired surrogates in text or quoted literals were an error.
A recent PR, unicode-org/message-format-wg#906 , made them allowable. This PR changes ICU4C to be consistent with the spec.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22953
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@catamorphism
Copy link
Contributor Author

Note: another PR, #3236 , changes the same parser code in order to use a UnicodeSet, but I'd rather keep this change separate and then rebase that PR after this one lands.

@catamorphism catamorphism marked this pull request as ready for review October 25, 2024 22:43
@catamorphism catamorphism merged commit 376da67 into unicode-org:main Nov 6, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants