Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22707 better doc HST=V != GCB=V #3205

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions icu4c/source/common/uprops.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -612,9 +612,9 @@ static int32_t scriptGetMaxValue(const IntProperty &/*prop*/, UProperty /*which*

/*
* Map some of the Grapheme Cluster Break values to Hangul Syllable Types.
* Hangul_Syllable_Type is redundant with a subset of Grapheme_Cluster_Break.
* Hangul_Syllable_Type used to be fully redundant with a subset of Grapheme_Cluster_Break.
*
* Starting with Unicode 16, there is an exception:
* Starting with Unicode 16, this is no longer true for HST=V vs. GCB=V in some cases:
* Some Kirat Rai vowels are given GCB=V for proper grapheme clustering, but
* they are of course not related to Hangul syllables.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@ public int getType(int c) {

/*
* Map some of the Grapheme Cluster Break values to Hangul Syllable Types.
* Hangul_Syllable_Type is redundant with a subset of Grapheme_Cluster_Break.
* Hangul_Syllable_Type used to be fully redundant with a subset of Grapheme_Cluster_Break.
*
* Starting with Unicode 16, there is an exception:
* Starting with Unicode 16, this is no longer true for HST=V vs. GCB=V in some cases:
* Some Kirat Rai vowels are given GCB=V for proper grapheme clustering, but
* they are of course not related to Hangul syllables.
*/
Expand Down