Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22900 Remove deprecated SimpleNumber truncateStart #3192

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 19, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22900
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@sffc sffc added the after-release Do not merge until after an upcoming release or at least until its maintenance branch has been cut. label Sep 19, 2024
@markusicu
Copy link
Member

This should ship in ICU 77

I don't see why this shouldn't go into 76. We are not removing anything that has ever been stable. The two functions that are to be removed went from draft ICU 73 to deprecated ICU 75, so anyone limiting themselves to stable API has never used them.

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Markus is right that we shouldn't jump the gun on promoting anything or do it in a special PR. I can take care of that the way I always do.

I'm agnostic on whether we should delete these APIs now or in 77, but I'm leaning toward Markus's position. The longer they're in there, the longer we have for people to start using them, making it worse when we get rid of them. And they're already marked as deprecated. I'm not sure I see the value in keeping them around.

@sffc sffc force-pushed the ICU-22900-truncatestart branch from abb827c to b61ba8b Compare September 20, 2024 01:07
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc changed the title ICU-22900 Remove deprecated truncateStart and promote draft setMaximumIntegerDigits ICU-22900 Remove deprecated SimpleNumber truncateStart Sep 20, 2024
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- please merge this today.

@sffc sffc removed the after-release Do not merge until after an upcoming release or at least until its maintenance branch has been cut. label Sep 20, 2024
@sffc sffc merged commit 94057e9 into unicode-org:main Sep 20, 2024
94 checks passed
@sffc sffc deleted the ICU-22900-truncatestart branch September 20, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants