-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22900 Remove deprecated SimpleNumber truncateStart #3192
Conversation
I don't see why this shouldn't go into 76. We are not removing anything that has ever been stable. The two functions that are to be removed went from draft ICU 73 to deprecated ICU 75, so anyone limiting themselves to stable API has never used them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Markus is right that we shouldn't jump the gun on promoting anything or do it in a special PR. I can take care of that the way I always do.
I'm agnostic on whether we should delete these APIs now or in 77, but I'm leaning toward Markus's position. The longer they're in there, the longer we have for people to start using them, making it worse when we get rid of them. And they're already marked as deprecated. I'm not sure I see the value in keeping them around.
abb827c
to
b61ba8b
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- please merge this today.
Checklist