Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22736 Improve Persian Calendar #3163

Merged
merged 2 commits into from
Dec 7, 2024
Merged

ICU-22736 Improve Persian Calendar #3163

merged 2 commits into from
Dec 7, 2024

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Sep 13, 2024 •
edited by markusicu
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22736
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@FrankYFTang FrankYFTang added the incomplete Needs work; do not approve/merge as is. label Sep 13, 2024
@FrankYFTang FrankYFTang force-pushed the ICU-22736-improvePersian branch from eddd7d8 to 31c345b Compare November 27, 2024 00:22
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/calendar.cpp is now changed in the branch
  • icu4c/source/i18n/persncal.cpp is different
  • icu4c/source/test/intltest/incaltst.cpp is different
  • icu4c/source/test/intltest/incaltst.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang force-pushed the ICU-22736-improvePersian branch from 31c345b to 0c15415 Compare November 27, 2024 02:43
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/main/java/com/ibm/icu/util/PersianCalendar.java is now changed in the branch
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/calendar/PersianTest.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang force-pushed the ICU-22736-improvePersian branch from 0c15415 to 6d467c8 Compare November 27, 2024 02:45
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/calendar.cpp is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang requested a review from sffc November 27, 2024 02:46
@FrankYFTang FrankYFTang removed the incomplete Needs work; do not approve/merge as is. label Nov 27, 2024
@FrankYFTang FrankYFTang force-pushed the ICU-22736-improvePersian branch from 6d467c8 to 69dd420 Compare November 28, 2024 01:19
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/intltest/incaltst.cpp is different
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/calendar/PersianTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang requested a review from roozbehp November 28, 2024 01:33
@FrankYFTang FrankYFTang requested review from markusicu and sffc and removed request for sffc December 2, 2024 21:58
@FrankYFTang
Copy link
Contributor Author

@sffc I need an approved reviewer to approve

FrankYFTang and others added 2 commits December 6, 2024 15:25
@FrankYFTang @markusicu
ICU-22736 Fix Persian calendar
3255e97 
ICU-22736 Add tests for java and make correction

Update icu4c/source/i18n/persncal.cpp

Co-authored-by: Markus Scherer <[email protected]>
@FrankYFTang
ICU-22736 Address Markus' feedback
f96b01a
@FrankYFTang FrankYFTang force-pushed the ICU-22736-improvePersian branch from c5e59cc to f96b01a Compare December 7, 2024 00:00
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/persncal.cpp is different
  • icu4j/main/core/src/main/java/com/ibm/icu/util/PersianCalendar.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang requested a review from markusicu December 7, 2024 00:12
@FrankYFTang FrankYFTang merged commit 2e57f07 into unicode-org:main Dec 7, 2024
101 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22736-improvePersian branch December 7, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@roozbehp roozbehp roozbehp approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @roozbehp @markusicu