Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22722 toTitle does not use UTR 21 #3162

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

markusicu
Copy link
Member

Fix API docs that claim that titlecasing functions use Unicode Technical Report #‌21 for the titlecase break iterator.
That was the case only for Unicode 3.2.
Use the wording from the Java API docs instead, which generically refers to the Unicode case mapping algorithms so that we need not adjust the docs every time this changes.

(Titlecasing has been using the word break iterator since Unicode 4.)

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22722
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@markusicu markusicu merged commit 4433a94 into unicode-org:main Sep 12, 2024
94 checks passed
@markusicu markusicu deleted the totitle-not-TR21 branch September 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants