Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22722 Prevent running PR check enforcement after merging PRs #3152

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Sep 11, 2024

Post-merge CI workflows run on every commit after it merges to main. However, we also use the setting that interrupts a workflow run when a new commit gets added to the branch.

In order to make commits on main in the Github UI not look like failures, we should not run the enforce-all-checks job after merging to main. This is the right change to make because the sole purpose of the enforce-all-checks job is to have intelligent automated enforcement of CI jobs before merging (that is: as a requirement before a PR is allowed to merge).

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22722
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echeran echeran merged commit c7caebd into unicode-org:main Sep 11, 2024
101 checks passed
@echeran echeran deleted the dont-enforce-checks-post-merge branch September 11, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants