Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22814 Run CIFuzz on PR #3142

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

FrankYFTang
Copy link
Contributor

CIFuzz ran on post merged since 7/20
https://github.com/unicode-org/icu/actions/workflows/cifuzz.yml

Turn to run on every PR

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22814
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu
Copy link
Member

@roubert FYI

Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be useful to also allow this to be triggered manually through workflow_dispatch?

.github/workflows/cifuzz.yml Outdated Show resolved Hide resolved
@mihnita
Copy link
Contributor

mihnita commented Sep 10, 2024

Would help if this would not fail.
It feels kind of wrong to approve the enablement of a test that fails :-)

@FrankYFTang
Copy link
Contributor Author

Would help if this would not fail. It feels kind of wrong to approve the enablement of a test that fails :-)

The failing is caused by the landing of 6c9d39a and roubert is fixing that in #3144 I need to rebase to pick up his fix.

CIFuzz ran on post merged since 7/20
https://github.com/unicode-org/icu/actions/workflows/cifuzz.yml

Turn to run on every PR
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/cifuzz.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit 6b00ed5 into unicode-org:main Sep 11, 2024
101 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22814-runCIFuzz branch September 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants