Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22874 Fix building with -Werror on macOS clang #3133

Merged
merged 1 commit into from
Sep 6, 2024
Merged

ICU-22874 Fix building with -Werror on macOS clang #3133

merged 1 commit into from
Sep 6, 2024

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Sep 6, 2024 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22874
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@rp9-next rp9-next mentioned this pull request Sep 6, 2024
Merged
7 tasks
@rp9-next rp9-next marked this pull request as ready for review September 6, 2024 09:17
roubert
roubert approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rp9-next rp9-next merged commit 6d67afc into unicode-org:main Sep 6, 2024
100 checks passed
@rp9-next rp9-next deleted the fix_Werror_for_macos branch September 6, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roubert roubert roubert approved these changes

@markusicu markusicu Awaiting requested review from markusicu

@echeran echeran Awaiting requested review from echeran

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rp9-next @roubert @echeran