Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22722 Update the ICU Vice-Chair for Maven publishing #3088

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Aug 6, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22722
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested a review from markusicu August 6, 2024 18:27
@markusicu markusicu self-assigned this Aug 6, 2024
@markusicu markusicu requested review from yumaoka and richgillam August 6, 2024 18:32
icu4j/pom.xml Outdated
<id>yumaoka</id>
<name>Yoshito Umaoka</name>
<organization>IBM</organization>
<id>richard_gillam</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richgillam -- Mihai picked this from your email address (from git log). Apparently this is kind of arbitrary. Would you prefer "richgillam" for your GitHub ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec: https://maven.apache.org/pom.html#developers

"id, name, email: These correspond to the developer's ID (presumably some unique ID across an organization), the developer's name and email address."

I tried to keep the info minimal (and consistent with what we had before).
The id is mandatory, the email not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer "richgillam" for your GitHub ID?

Well, my GitHub ID is "richgillam". Or is that your point: Use "richgillam" from the GitHub ID as opposed to "richard_gillam" from my (Apple) email address? I think I like "richgillam" because it's shorter, but I'm not sure it matters that much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer "richgillam" for your GitHub ID?

Well, my GitHub ID is "richgillam". Or is that your point: Use "richgillam" from the GitHub ID as opposed to "richard_gillam" from my (Apple) email address?

Well, I tried to make that point but wasn't clear.

I think I like "richgillam" because it's shorter, but I'm not sure it matters that much.

I suggest that we use GitHub IDs here and add a comment line about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mihnita mihnita force-pushed the mihai_fix_icu4j_vicechair branch from 79d0bae to dac73b5 Compare August 7, 2024 00:09
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/pom.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mihnita mihnita merged commit 366bb46 into unicode-org:main Aug 7, 2024
16 checks passed
@mihnita mihnita deleted the mihai_fix_icu4j_vicechair branch August 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants