ICU-22825 Fix memLeak during error in tznames_impl.cpp

[FrankYFTang]

Checklist

• Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22825
• Required: The PR title must be prefixed with a JIRA Issue number.
• Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• Required: Each commit message must be prefixed with a JIRA Issue number.
• Issue accepted (done by Technical Committee after discussion)
• Tests included, if applicable
• API docs and/or User Guide docs changed or added, if applicable

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• icu4c/source/i18n/tznames_impl.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[richgillam]

I think this is right. I was concerned that you might need to take ownership of both the key and the value, but the documentation says this particular function is for cases where the key is in static memory owned by somebody else (the resource bundle), so I think you're doing the right thing.

[FrankYFTang]

@sffc could you double check since you are the one who wrote the origional code.

[sffc]

The minimal fix would be to change fValueDeleter((void*) key); to fValueDeleter(value);

The rest of the refactor looks fine.

[FrankYFTang]

The minimal fix would be to change fValueDeleter((void*) key); to fValueDeleter(value);

no, that will not be enugh because for the last line of
fLazyContents->addElement(value, status); in the origional line 255
we also need a "if fail if deleter delete block" in case the return status faile also. That is the leak the reporter detected.

addressed in other file