Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22814 Add CIFuzz to ICU #3059

Merged
merged 1 commit into from
Jul 19, 2024
Merged

ICU-22814 Add CIFuzz to ICU #3059

merged 1 commit into from
Jul 19, 2024

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Jul 1, 2024 •
edited
Loading

per instruction on https://google.github.io/oss-fuzz/getting-started/continuous-integration/

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22814
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang requested a review from echeran July 1, 2024 23:44
@FrankYFTang FrankYFTang requested a review from richgillam July 1, 2024 23:44
richgillam
richgillam previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about .yml files, so I'm not sure I'm qualified to review this. If it works for you, it's probably fine, but if there's a latent problem in here, I'm not the guy to find it.

FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Jul 19, 2024
@FrankYFTang
ICU-22814 Add CIFuzz to ICU
64130f8 
See unicode-org#3059
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

richgillam
richgillam approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as before. I don't really know what I'm looking at, but if it works for you, I'll rubber-stamp it.

@FrankYFTang FrankYFTang merged commit 40b2ec3 into unicode-org:main Jul 19, 2024
82 checks passed
@FrankYFTang FrankYFTang deleted the addCIFuzz branch July 19, 2024 22:53
mihnita pushed a commit to mihnita/icu that referenced this pull request Aug 10, 2024
@FrankYFTang @mihnita
ICU-22814 Add CIFuzz to ICU
b83640b 
See unicode-org#3059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees

@echeran echeran

@richgillam richgillam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @richgillam @echeran