-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22714 fix zos build, use OpenXL #3008
ICU-22714 fix zos build, use OpenXL #3008
Conversation
6697a6b
to
c68ce7f
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
423a492
to
f4050de
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
lots of good deletion here! For the BOMs, would it make sense just to fix them up with a build step? |
OpenXL is basically clang, that allowed me to get rid of many "OS390 only" code and tricks. Actually i have found one bug in OpenXL v2.1, it fails to generate correct name for sidedeck if output path is relative and library name has no suffix, for output library path like: I have added BOM fix in build time generated index files, also made sure those generated as UTF-8. But regarding this files: |
Hello @markusicu @srl295 what is missing for this PR to be merged? |
@markusicu LGTM ready to merge? |
Hello @markusicu , can we merge this? is anything missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for dropping the ball here! Let's get this in.
Happy to see that there are no merge conflicts.
Fingers crossed that the post-merge CI checks will still be green...
@@ -368,55 +368,54 @@ Some platforms use package management tools to control the installation and unin | |||
|
|||
## How To Build And Install On z/OS (OS/390) | |||
|
|||
You can install ICU on z/OS or OS/390 (the previous name of z/OS), but IBM tests only the z/OS installation. You install ICU in a z/OS UNIX system services file system such as HFS or zFS. On this platform, it is important that you understand a few details: | |||
You can install ICU on z/OS or OS/390 (the previous name of z/OS), but IBM tests only the z/OS installation. You install ICU in a z/OS UNIX System Services (z/OS UNIX) file system such as HFS or zFS. On this platform, it is important that you understand a few details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: IBM hasn't been testing anything for a long time... :-}
f4050de
to
dc4b490
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I had to rebase in order to make a newer CI check work. Now we find out if it still works with the latest checks, even pre-merge... |
I have fixed the git clone of this repo on zos and moved build from old XLc compiler to new OpenXL compiler.
More details https://unicode-org.atlassian.net/browse/ICU-22714
As of now:
icu4c/source/data/misc/currencyNumericCodes.txt
icu4c/source/data/misc/icustd.txt
icu4c/source/data/misc/zoneinfo64.txt
Checklist