Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21757 Replace UOption with commons-cli in perf-tests #2993

Merged
merged 1 commit into from
May 3, 2024
Merged

ICU-21757 Replace UOption with commons-cli in perf-tests #2993

merged 1 commit into from
May 3, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented May 1, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21757
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita marked this pull request as draft May 1, 2024 20:44
@mihnita mihnita assigned srl295 and markusicu and unassigned srl295 and markusicu May 2, 2024
@mihnita mihnita requested review from srl295 and markusicu May 2, 2024 15:18
@mihnita mihnita marked this pull request as ready for review May 2, 2024 15:19
@markusicu markusicu self-assigned this May 2, 2024
@markusicu markusicu requested review from echeran and yumaoka May 2, 2024 16:44
srl295
srl295 previously approved these changes May 2, 2024
View reviewed changes
@mihnita
Copy link
Contributor Author

mihnita commented May 3, 2024

@srl295

Sorry, I did another commit updating the perl scripts (many didn't work even before this).
And modified the maven pom.xml to do the copy-dependencies, so that we don't have to remember to do it everywhere.

But now GitHub says srl295 left review comments and mihnita dismissed srl295’s stale review via 907a5b0 5 minutes ago

I don't remember seeing any comments, and I looked everywhere to find them.
Even in the email that github sent to tell me you approved.

If you had some comment, I apologize, I didn't intend to dismiss them.
But thing is, I can't find them, so I would appreciate if you comment again.

If you had no comments, then I will add another entry to my "annoying things that GitHub does" list :-)

Thank you,
Mihai

@mihnita mihnita requested a review from srl295 May 3, 2024 18:40
markusicu
markusicu reviewed May 3, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(partial rs) lgtm

icu4j/perf-tests/README.txt Outdated Show resolved Hide resolved
icu4j/perf-tests/src/main/java/com/ibm/icu/dev/test/perf/PerfTest.java Outdated Show resolved Hide resolved
markusicu
markusicu previously approved these changes May 3, 2024
View reviewed changes
echeran
echeran reviewed May 3, 2024
View reviewed changes
icu4j/perf-tests/converterperf.pl Outdated Show resolved Hide resolved
icu4j/perf-tests/dateformatperf.pl Outdated Show resolved Hide resolved
icu4j/perf-tests/normperf.pl Outdated Show resolved Hide resolved
@mihnita
Copy link
Contributor Author

mihnita commented May 3, 2024

(partial rs) lgtm

Thank you, I accepted the typo fixes.

Let me know (when the time comes) if you want to go with the usual squash and merge.
If not I can "tinker" with the history a bit and merge the 2 type fixes into the last commit, to submit with 4 clean commits.

Thank you,
M.

@markusicu
Copy link
Member

Thank you, I accepted the typo fixes.

Elango has some more feedback.

Let me know (when the time comes) if you want to go with the usual squash and merge. If not I can "tinker" with the history a bit and merge the 2 type fixes into the last commit, to submit with 4 clean commits.

Your choice.

echeran
echeran reviewed May 3, 2024
View reviewed changes
icu4j/perf-tests/src/main/java/com/ibm/icu/dev/test/perf/PerfTest.java Show resolved Hide resolved
icu4j/perf-tests/src/main/java/com/ibm/icu/dev/test/perf/PerfTest.java
fis = new FileInputStream(filename);
isr = new InputStreamReader(fis, srcEncoding);
br = new BufferedReader(isr);
try (FileInputStream fis = new FileInputStream(filename);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I like the Java 7 style "try-with-resources". If you're adventurous, you can tidy up the body using Java 8 Streams to convert the buffered input stream to a Stream of strings (SO link)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to mess with that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SO option is still too verbose :-)
Even shorter: static Stream<String> Files.lines(Path path, Charset cs)

icu4j/perf-tests/perftests.pl Outdated Show resolved Hide resolved
echeran
echeran approved these changes May 3, 2024
View reviewed changes
icu4j/perf-tests/collationperf.pl
if ($OS eq "linux" || $OS eq "darwin") {
$CLASSPATH = './target/*:./target/dependency/*';
} else {
if ($^O eq "MSWin32") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: use the alias $OS that you defined above (presumably to be more human readable) rather than $^O

@mihnita
Copy link
Contributor Author

mihnita commented May 3, 2024

Thank you, I accepted the typo fixes.

Elango has some more feedback.

Let me know (when the time comes) if you want to go with the usual squash and merge. If not I can "tinker" with the history a bit and merge the 2 type fixes into the last commit, to submit with 4 clean commits.

Your choice.

Implemented Elango's feedback.
And I think I'll squash :-)

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit 69cb085 into unicode-org:main May 3, 2024
81 checks passed
@mihnita mihnita deleted the mihai_no_uoption branch May 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran echeran approved these changes

@markusicu markusicu markusicu left review comments

@yumaoka yumaoka Awaiting requested review from yumaoka

@srl295 srl295 Awaiting requested review from srl295

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihnita @markusicu @srl295 @echeran