Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22583 CLDR release-44-1 to ICU maint/maint-74 branch #2727

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Dec 7, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22583
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MULTIPLE_COMMITS=true

This integrates CLDR release-44-1 to ICU maint/maint-74 for ICU 74.2. The main CLDR data change that affects ICU is cleaning up sequences of multiple spaces of different types in several locales; typical a regular space plus either NNBSP or THIN SPACE. Also the CLDR version gets updated many places, notably in collation data files. This has the same problem noted in ICU 74.1 #2682 with stub files for kxv getting deleted in data trees other than locales; they are manually re-added here as in that PR.

The commits are in 4 groups:

  1. Binary data, and binary-like source data (No review needed)
  2. Data generated or copied from CLDR (Can spot check)
  3. Tool and test changes
  4. Manually re-add kxv_Latn* stubs, as in PR ICU-22326 Integrate CLDR release-44-beta5 to ICU #2682

ALLOW_MULTIPLE_COMMITS=true

@pedberg-icu
Copy link
Contributor Author

/azp run CI-Exhaustive

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@DraganBesevic DraganBesevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedberg-icu
Copy link
Contributor Author

ICU-22583 CLDR release-44-1 to ICU maint/maint-74 branch, 4 separate commits (#2727)

@pedberg-icu pedberg-icu merged commit 598b488 into unicode-org:maint/maint-74 Dec 7, 2023
101 of 102 checks passed
@pedberg-icu pedberg-icu deleted the ICU-22583-CLDR-44-1-to-ICU-maint-74-branch branch December 7, 2023 18:35
@@ -83,7 +83,7 @@
<dependency>
<groupId>com.ibm.icu</groupId>
<artifactId>icu4j</artifactId>
<version>74.1-SNAPSHOT</version>
<version>74.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this version number used?
Does it matter that it's at 74.1 now but we are about to release 74.2?
Does it matter that #2728 does not touch this version number?

@pedberg-icu @rp9-next @mihnita

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version of icu used by the cldr-icu tooling. I do not think any change in 74.2 would affect the behavior of that tooling; and since the vision number had not been updated when I did the integration (so there was no icu4j artifact for 74.2), I could not use 74.2 anyway. No need for #2728 to touch this because we will not be doing another cldr-icu integration for 74.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants